fix: remove eventsource dependency (#2052)

* fix: remove eventsource dependency * also remove eventsource types * remove reference to eventsource import in test file
probot · Jul 13, 2024 · caee841 · caee841
1 parent cc86a53
commit caee841
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 16 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -53,7 +53,6 @@
     "commander": "^12.0.0",
     "deepmerge": "^4.3.1",
     "dotenv": "^16.3.1",
-    "eventsource": "^2.0.2",
     "express": "^4.18.2",
     "ioredis": "^5.3.2",
     "js-yaml": "^4.1.0",
@@ -69,7 +68,6 @@
     "@octokit/webhooks-examples": "^7.3.1",
     "@octokit/webhooks-methods": "^4.0.0",
     "@octokit/webhooks-types": "^7.3.1",
-    "@types/eventsource": "^1.1.15",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "^20.0.0",
     "@types/supertest": "^6.0.0",

diff --git a/src/helpers/webhook-proxy.ts b/src/helpers/webhook-proxy.ts
@@ -1,5 +1,3 @@
-import EventSource from "eventsource";
-
 import type { Logger } from "pino";
 
 export const createWebhookProxy = async (
@@ -13,7 +11,7 @@ export const createWebhookProxy = async (
       target: `http://localhost:${opts.port}${opts.path}`,
       fetch: opts.fetch,
     });
-    return smee.start();
+    return smee.start() as EventSource;
   } catch (error) {
     opts.logger.warn(
       "Run `npm install --save-dev smee-client` to proxy webhooks to localhost.",

diff --git a/src/server/server.ts b/src/server/server.ts
@@ -10,7 +10,6 @@ import { createWebhookProxy } from "../helpers/webhook-proxy.js";
 import { VERSION } from "../version.js";
 import type { ApplicationFunction, ServerOptions } from "../types.js";
 import type { Probot } from "../index.js";
-import type EventSource from "eventsource";
 import { rebindLog } from "../helpers/rebind-log.js";
 
 // the default path as defined in @octokit/webhooks

diff --git a/test/webhook-proxy.test.ts b/test/webhook-proxy.test.ts
@@ -9,7 +9,6 @@ const sse: (
   next: express.NextFunction,
 ) => void = require("connect-sse")();
 import fetchMock from "fetch-mock";
-import EventSource from "eventsource";
 import { describe, expect, afterEach, test, vi } from "vitest";
 import { getLog } from "../src/helpers/get-log.js";
 import { createWebhookProxy } from "../src/helpers/webhook-proxy.js";