(Gsoc'21) (Week-1) Fixes broken tests #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
awesome, @satyasaibhushan !
I commented with a few questions.
Also, for future PR's that are focused on tests, I'd try to avoid including the re-compiled library as part of the PR commits.
|
Part 3 focuses on correcting the broken tests in firefox. |
therewasaguy
approved these changes
Jul 16, 2021
|
Hey @therewasaguy, did you also check the commit-3 i.e, part-3 ? |
|
yes, feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken tests in the library.
Many of these fixes are small, like adding a timeout.
I've corrected all the tests which were broken in chrome, will add more commits if any of the tests fail in other browsers in the future.