Resolves #5481 Set uniform arrays bug #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting up to date
Arrays were not being properly detected based on uniform type information. Once fixing this, I also had to detect if arrays were being passed to `setUniform` and make a shallow copy there to make sure we update cached uniforms correctly.
|
Thank you! |
stalgiag
added a commit
that referenced
this pull request
Jan 14, 2022
Fixes bug introduced by #5483
This was referenced Feb 3, 2022
Open
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #5481.
The existing check for uniform array types was implemented incorrectly and returning false when it shouldn't have. I've updated p5.Shader.js to properly detect arrays.
Once fixing this, I also discovered that it had the side of effect of breaking uniforms being set from regular javascript arrays, so I modified a line or two in setUniform to check for arrays being passed to
setUniformand make a shallow copy if they're found.PR Checklist
npm run lintpasses