Skip to content

Conversation

jencce
Copy link

@jencce jencce commented Feb 26, 2025

Add "login" for Jira username;
Add "token_name" for gitlab token name;

Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
type = gitlab
url = https://gitlab.com/
token = <authentication-token>
token_name = <authentication-token>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a change in the config renaming the option token in token_name. I think this change has been added by mistake.

token_file = ~/.did/jira-token
token_expiration = 7
token_name = did-token
login = username
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection adding this despite the plugin works even without setting login as long as email is properly set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants