Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set comment field via collection create/update api #4586

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ding-young
Copy link
Contributor

@ding-young ding-young commented Jun 30, 2024

/claim #3957

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
    There's an open pr for this issue, but it seems like idle at this moment.

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

This PR adds an optional comment field to the config and enhances the collection create/update API to set this field.
I have tested both REST and gRPC APIs via the web UI and terminal, and added an integration test for the comment update in tests/openapi/openapi_integration/test_collection_update.py.

@ding-young
Copy link
Contributor Author

@generall Hi, may I ask for a review of my pull request? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant