Added more options for custom claws in TransmonCross #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for a review? |
Yeah ready! |
There was a problem hiding this comment.
Looks good to me overall, just double check this should be backward-compatible, right?
in other words, people who have made previous designs using this, won’t even notice a difference when loading the updated version. Unless you change one of these options, right
Correct. If the user doesn't input |
|
It's overall looking good to me, I'll plan to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
Slight corrections & improvements to #949
Did you add tests to cover your changes (yes/no)?
Yes, updated corresponding tests for
TransmonCross.Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
The standard MIT LL candle qubit has a nonuniform claw thickness. One of the assumptions in the current
TransmonCrossis that you have uniform claw thickness, so this design isn't possible in Qiskit Metal (before this PR!). This update is to give front-end users more control of their claw designs.To illustrate what I mean here's a new potential design you can create.
And yes, it is backward compatible!
Details and comments
TransmonCrossclaws.connector_type = 1