Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1419] Move controller specs to request specs #1481

Merged
merged 1 commit into from
Jan 31, 2020
Merged

[1419] Move controller specs to request specs #1481

merged 1 commit into from
Jan 31, 2020

Conversation

moacirguedes
Copy link
Contributor

Resolve partially #1419

Description

I moved barcode_items_controller_spec and dashboard_controller_spec to barcode_items_requests_spec and dashboard_requests_spec respectively, with the necessary changes.

Type of change

  • Improvement

How Has This Been Tested?

All tests were green.

Screenshots

@auto-comment
Copy link

auto-comment bot commented Jan 31, 2020


Thank you for your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
Best,
@rubyforgood/diaper-team

@seanmarcia
Copy link
Member

This is fantastic, thank you for this! We appreciate the setup you've done that will make it easier for everyone else! :)

@seanmarcia seanmarcia merged commit a8ca2a7 into rubyforgood:master Jan 31, 2020
@moacirguedes moacirguedes deleted the 1419-barcode-dashboard-controllers branch February 3, 2020 14:15
@armahillo armahillo added the Repo First-timer This Pull Request is a user's first contribution to Diaperbase label Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repo First-timer This Pull Request is a user's first contribution to Diaperbase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants