Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forward ref to react/select:Select #2591

Closed
wants to merge 1 commit into from
Closed

Add forward ref to react/select:Select #2591

wants to merge 1 commit into from
+112 −104

Conversation

Roanmh
Copy link

@Roanmh Roanmh commented Dec 14, 2023

Description

Closes #2590 (More detail in issue description)

Select component needs to forward a ref to BubbleSelect to be compatible with react-hook-form's register() function.

@phsantiago
Copy link

Hello @benoitgrelard, @andy-hook any updates here?

@chaance
Copy link
Member

chaance commented Sep 26, 2024

I think we need to fix this in other components that do this as well, but I'm not sure this is exactly the solution we want. I need to think through this a bit more to land on a more wholistic solution. Not sure we'll keep the bubble elements in the end.

@chaance chaance closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard Awaiting requested review from benoitgrelard

@andy-hook andy-hook Awaiting requested review from andy-hook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ref in Select Component
3 participants
@Roanmh @phsantiago @chaance