E2e send L2 transaction #6788
E2e send L2 transaction #6788
Conversation
e2e/utils/FundPolygonWallet.yaml
Outdated
| --- | ||
| # Fund the test wallet with Polygon tokens | ||
| - tapOn: | ||
| id: fund-polygon-wallet-button |
There was a problem hiding this comment.
jw why this is a separate file instead of just inline in the test itself? I don't mind if it's necessary but seems funny.
src/helpers/RainbowContext.tsx
Outdated
| } | ||
|
|
||
| // Fund the test wallet with ETH directly (this will be detected as the native asset) | ||
| // The issue is that Polygon on Anvil should use ETH as the gas token, not POL |
There was a problem hiding this comment.
so this comment isn't accurate actually in a live environment, Polygon should be using POL as the gas token. is this a quirk of Anvil?
There was a problem hiding this comment.
@BrodyHughes I updated the comment to make it more easy to read.
| logger.error(new RainbowError(`[anvilAssets]: Error fetching balances from Anvil node: ${e}`)); | ||
| return null; | ||
|
|
||
| // Fallback: return configured quantities for testnet when balance checks fail |
There was a problem hiding this comment.
this is nice! i noticed when testing that the balances populated immediately and I'm guessing this is the cause.
There was a problem hiding this comment.
Yes my tought was to make it faster/simpler for testing purpose.
src/state/assets/utils.ts
Outdated
|
|
||
| if (testnetMode) { | ||
| const { assets, chainIdsInResponse } = await fetchAnvilBalancesByChainId(address, ChainId.mainnet); | ||
| const { assets, chainIdsInResponse } = await fetchAnvilBalancesByChainId(address, ChainId.anvil); |
There was a problem hiding this comment.
do we need to concat the two here instead of changing to anvil? I know our anvil instance is spun up using a chainId of 1 (which is mainnet). I wonder if were doing two things now:
- adding fallback balances that are on
ChainId.anvil - sending dev funds on a mainnet fork with anvil using
ChainId.mainnet
wdyt?
There was a problem hiding this comment.
@BrodyHughes I did make an update where I concat them. Thank you !
This add E2E testing for L2 Transaction