Skip to content

small tweaks? #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2023
Merged

small tweaks? #112

merged 2 commits into from
Jul 26, 2023

Conversation

littlewhitecloud
Copy link
Contributor

@littlewhitecloud littlewhitecloud commented Jul 26, 2023 •
edited
Loading

LOL Maybe someone like me often write set_theme("Dark"), so I think we can add .lower() to avoid the check fails.
Also think we can use

cls.set_theme("dark" if cls.get_theme() == "light" else "light")

instead of

if cls.get_theme() == "light":
    cls.set_theme("dark")
else:
    cls.set_theme("light")

Akuli
Akuli reviewed Jul 26, 2023
View reviewed changes
rdbende
rdbende requested changes Jul 26, 2023
View reviewed changes
@littlewhitecloud @Akuli
Update sv_ttk/__init__.py
17493e6 
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@rdbende rdbende merged commit 0ce7210 into rdbende:main Jul 26, 2023
@rdbende
Copy link
Owner

rdbende commented Jul 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdbende rdbende rdbende approved these changes

+1 more reviewer

@Akuli Akuli Akuli left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littlewhitecloud @rdbende @Akuli