Expose multicolor highlights to MinimalLib #7787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure that out-of-bounds atom indices in highlight_atom_map do not cause a segfault
greglandrum
reviewed
Sep 3, 2024
| @@ -203,6 +203,7 @@ void DrawMolMCHCircleAndLine::calcSymbolEllipse(unsigned int atomIdx, | |||
| Point2D ¢re, | |||
| double &xradius, | |||
| double &yradius) const { | |||
| PRECONDITION(atomIdx < atCds_.size() && atomIdx < atomLabels_.size(), "") | |||
There was a problem hiding this comment.
I will approve as-is, but it's not terrible to actually use that final argument to explain the failure. ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the multi-color highlight functionality to MinimalLib and adds relevant tests.
This code was originally part of #7322 and I have now extracted it to make #7322 easier to review.
I have also added a
PRECONDITIONinDrawMolMCHCircleAndLine::calcSymbolEllipseas I incurred in a segfault while testing with out-of-bounds atom indices, and added relevant tests .