Skip to content

Conversation

nicola-cab
Copy link
Member

What, How & Why?

Compressing integer arrays essentially means changing the layout of the array itself and changing the way in which the data is committed and accessed. In order to verify that there are no regressions, we introduce a new builder in which we force the compression of all the arrays, and we run all the unit tests.

Fixes: https://jira.mongodb.org/browse/RCORE-2057
Depends on: #7664

nicola-cab and others added 30 commits March 25, 2024 14:05
---------

Co-authored-by: Finn Schiermer Andersen <finn.schiermer.andersen@gmail.com>
@cla-bot cla-bot bot added the cla: yes label May 1, 2024
@nicola-cab nicola-cab changed the title RCORE-2057 New builder for assess that compression is working correctly RCORE-2057 New builder for assessing that compression is working correctly May 1, 2024
Copy link

coveralls-official bot commented May 1, 2024

Pull Request Test Coverage Report for Build nicola.cabiddu_1713

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 70 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.609%

Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 87.23%
src/realm/util/serializer.cpp 1 90.43%
test/fuzz_tester.hpp 1 57.73%
src/realm/cluster.cpp 2 74.28%
src/realm/db.cpp 2 91.61%
src/realm/sync/noinst/server/server.cpp 3 74.07%
src/realm/bplustree.cpp 6 68.86%
src/realm/sync/noinst/client_impl_base.cpp 6 82.48%
src/realm/index_string.cpp 8 84.63%
test/fuzz_group.cpp 40 40.67%
Totals Coverage Status
Change from base Build nicola.cabiddu_1712: -0.02%
Covered Lines: 215664
Relevant Lines: 238015

💛 - Coveralls

Base automatically changed from nc/RCORE-2058 to next-major May 21, 2024 14:48
@nicola-cab nicola-cab merged commit 222832d into next-major May 21, 2024
@nicola-cab nicola-cab deleted the nc/rcore-2057 branch May 21, 2024 14:55
@nicola-cab nicola-cab changed the title RCORE-2057 New builder for assessing that compression is working correctly RCORE-1624 RCORE-2057 New builder for assessing that compression is working correctly Jun 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants