Implement optionalQueryParam Following Discussion in #1751 #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rest-assured#1751 If this QueryParam value is null, no query parameter is added If not null, the query parameter is added with the given parameter name and value.
|
@beng9re Thanks again for a nice PR. However, I'm a little hesitant to merge this because I suspect (but I could be wrong) that it's a rather slim use case and it would add significantly more methods to the API (we should add it for form parameters as well etc). I understand that's a bit cumbersome to deal with this in Java, but in Kotlin (which I use most of the time) it's easy to write your own extension function. Also, this PR only address it for mock-mvc, not the "core", kotlin or web-test API so it would require more work to make it consistent. So before I put effort into this, I'd like to hear your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
optionalQueryParammethod to theMockMvcRequestSpecificationclass, as discussed in issue #1751.Implementation Details
The
optionalQueryParammethod enhances request building by conditionally adding query parameters:Discussion Reference
This implementation follows the specifications and considerations discussed in issue #1751, aiming to address the need for optional query parameters in our request handling logic.
Testing
Tests have been added to verify that the
optionalQueryParammethod behaves as expected, ensuring that parameters are correctly added only when their values are not null.