Remove version parameter in Winget workflow
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
approved these changes
Jun 2, 2023
|
Thanks. I apologize for the delay. |
|
@sitiom Winget workflow fails after this PR. Do you know the reason? https://github.com/rhysd/actionlint/actions/runs/5280674972/jobs/9553198795 |
|
Maybe it could be that your token is invalid, but I also see the mismatched installer URLs, which should be a Komac bug. @russellbanks |
|
I checked the token, but it was valid and not expired. I know that the same token worked before.
OK, I will make an issue tomorrow. |
|
Oh, an issue is already open for it: |
|
Thanks. Then I can track the ticket. |
|
Meanwhile, I have manually created a PR for the new version: |
|
Thank you. It's very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
versionparameter is optional and derived from therelease-tag, which usually cuts thevprefix from it. Otherwise, it would lead to an incorrectPackageVersionsuch as microsoft/winget-pkgs#102052.