This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage0: list|status --format=json panics: RuntimeApp.Mounts.AppVolume is optional #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
lucab
suggested changes
Jun 8, 2017
lib/app.go
Outdated
| var ( | ||
| podVols = podManifest.Volumes | ||
| podVolsByName = make(map[types.ACName]types.Volume, len(podVols)) | ||
| ) |
There was a problem hiding this comment.
I would avoid this inline var( ... ) block and just go for two plain := assignments.
lib/app.go
Outdated
| for _, mnt := range ra.Mounts { | ||
| var ( | ||
| hostPath string | ||
| readOnly bool // false by default, since it is optional |
There was a problem hiding this comment.
Same here, let's just make it explicit as readOnly := false.
When it is nil, the Volume info at the Pod level (with the same name) should be used. Without this patch `rkt list --format=json` panics on a nil pointer when Apps reference Volumes from the Pod level. Signed-off-by: Fabio Kung <fabio.kung@gmail.com>
|
@lucab I made the changes you suggested. PTAL |
euank
approved these changes
Jun 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it is nil, the Volume info at the Pod level (with the same name)
should be used. Without this patch
rkt list --format=jsonpanics on anil pointer when Apps reference Volumes from the Pod level.
Signed-off-by: Fabio Kung fabio.kung@gmail.com