Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prism release-please process removed #2596

Closed
wants to merge 1 commit into from
Closed

fix: Prism release-please process removed #2596

wants to merge 1 commit into from
+16,195 −1,157

Conversation

SB-pradeep-bande
Copy link

Addresses #STOP972

Summary

As per requirement, removed the release-please configuration and updated CHANGELOG.md from root directory.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots
section before creating the PR.

Additional context

Add any other context about the pull request here. Remove this section if there is no additional context.

@SB-pradeep-bande SB-pradeep-bande requested a review from a team as a code owner August 29, 2024 15:24
lukaszzazulak
lukaszzazulak reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@lukaszzazulak lukaszzazulak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the release please will cause us to follow manual process fully, which will take longer time than current release process.

What are the arguments for removing the release please ?

@lukaszzazulak
Copy link
Contributor

Please provide arguments in favor of removing the release-please tool.
Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszzazulak lukaszzazulak lukaszzazulak left review comments

@bhaskarsontakke bhaskarsontakke Awaiting requested review from bhaskarsontakke

@SB-akshaythakar SB-akshaythakar Awaiting requested review from SB-akshaythakar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SB-pradeep-bande @lukaszzazulak @bhaskarsontakke @SB-akshaythakar