Added experimental Kissat support #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nimdanaoto <matsuoka.kotaro@gmail.com>
|
I also wrote the PR for Kissat to request merging my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
First of all, this PR is not intended for the immediate merge because this includes modification on kissat which is currently handled by my forked version.
As you may know, Kissat is the winner of this year's SAT competition, and its latest version is supported in Bitwuzla. Since both STP and Bitwuzla are state-of-the-art SMT solvers for the QF_BV problem, some people like me may want to compare them using the state-of-the-art SAT solver, kissat.
Hence, I wrote this PR. This PR can include some code not obeying STP's coding rules like explicit use of 'make' for building Kissat because Kissat does not support CMake at all.
I hope that some people who have the same need, comparing the state-of-the-art SMT solvers, can find some insights in this PR.