-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to THREE r89 #11
Conversation
@RemusMar SEA3D.js is an SDK. It should have no dependence. |
What dependence? |
In this case, we should |
See this: extractUrlBase: function ( url ) {
var parts = url.split( '/' );
if ( parts.length === 1 ) return './';
parts.pop();
return parts.join( '/' ) + '/';
} |
Not true. this.config.path = THREE.Loader.prototype.extractUrlBase( url ); So we should keep them both. |
it is a bug.
So one can use sea3d in another library for example... but the purpose is not this. I think in sea3d.js should be like this: if (!this.config.path) {
this.config.path = this.extractUrlBase( url );
} |
"extractUrlBase" does not exist in the SEA3D files. |
If you want to make SEA3D independent of THREE, you need to include both functions from LoaderUtils to SEA3D. |
In my opinion: for r89 we should keep them how they are now. |
Yes, my suggests we should add
I do not think that some lines of code will overload something. My concern would be just with maintaining of code but for this case is necessary that sea3d.js has no dependency. |
Again, In my opinion: for r89 we should keep them how they are now. |
You're sure this work for oriental characters? |
No, I'm not. SEA3D.LoaderUtils.prototype = { starting with r90. |
Try naming a 3d object in sea3d to |
Can they do that in THREE ? |
Not using this approach. Its work done to ASCII but not UTF8 (pure). |
We updated SEA3D for THREE. |
No, no! SEA3D must have support to oriental characters. Three.js can use oriental characters with another approach if wish. It is important that the sea3d.js approach work done. |
I tried to keep. return decodeURIComponent( escape( String.fromCharCode.apply( null, new Uint8Array( buffer ) ) ) ); But they didn't like the idea. |
Today I can not it because of lack of time, but tomorrow I am going to do a PR in threejs about it. |
It's better to make a PR on their LoaderUtils. |
See the latest SEA3D update. |
I see, I see. That is it, I will merger it soon. |
No description provided.