@hamishknight Looks good ^? Could you ask it to test?

@hamishknight look all good?

@swift-ci please test

@hamishknight looks like we couldn't use types from the stdlib, fixed that, could you ask it to test again?

Yeah -parse-stdlib disables the implicit stdlib import as it's primarily used for building the standard library

@swift-ci please test

@AnthonyLatsis did Linux just immediately fail?

@swift-ci please test Linux

Probably just Jenkins flakiness

@hamishknight seems it’s working, could you ask it to build a toolchain?

@swift-ci please build toolchain

Works locally :)

@hamishknight Ready for merge now?

Implementation looks good to me, though I think this will probably require evolution discussion before being merged.

Implementation looks good to me, though I think this will probably require evolution discussion before being merged.

I’ve opened a discussion post here, one thing I was considering was @available support aswell but that doesn’t seem too reasonable considering that most devs don’t know the Darwin-XNU version numbers for each release, what do you think?

Yeah, note you would also need a way to map the Darwin version numbers to the individual platform version numbers, which I'm not sure we'd want to bake into the compiler. FWIW we use availability macros (e.g SwiftStdlib 5.7) for this kind of purpose in the stdlib. These mappings are defined in https://github.com/apple/swift/blob/main/utils/availability-macros.def, and are passed as compiler arguments when compiling the stdlib specifically, so aren't a hardcoded feature of the compiler. See https://github.com/apple/swift/blob/649889fd5e566ad18c6bb27258a1e11b5df96421/docs/StandardLibraryProgrammersManual.md#availability.

Thank you for tackling this!

@CodaFi Could you ask CI to test?

@swift-ci smoke test

@CodaFi Works great! Thanks for letting me know of that method, all that's left now is for the proposal to be reviewed & approved, which I just opened yesterday

mistake^

It's been a while so let's re-test this

@swift-ci smoke test

is ci borked

The trigger I used picked up my words and tried to interpret them as a repository.

@swift-ci smoke test

I think we should exclude DriverKit from #if os(Darwin), since it's quite different from the other platforms currently covered by Target.isOSDarwin(). (I would comment on the source line in question, but I get an error from Github when I try that.)

i.e. instead of Target.isOSDarwin(), it should be Target.isOSDarwin() && !Target.isDriverKit(), I think.

I think we should exclude DriverKit from #if os(Darwin), since it's quite different from the other platforms currently covered by Target.isOSDarwin(). (I would comment on the source line in question, but I get an error from Github when I try that.)

i.e. instead of Target.isOSDarwin(), it should be Target.isOSDarwin() && !Target.isDriverKit(), I think.

The pr is dead. Though I agree