Implement the mimalloc option to speed up the compiler on Windows #76563
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
reviewed
Sep 19, 2024
utils/build.ps1
Outdated
| @@ -102,6 +102,9 @@ in batch file format instead of executing them. | |||
| .PARAMETER HostArchName | |||
| The architecture where the toolchain will execute. | |||
| .PARAMETER EnableMimalloc | |||
There was a problem hiding this comment.
I wonder if we should generalise this to something like -allocator ... to experiment with other allocators.
| [hashtable]$Arch | ||
| ) | ||
|
|
||
| if ($Arch -eq $ArchX64) { |
There was a problem hiding this comment.
Can we abort if a different architecture is passed? Or is this being allowed for some other reason? As this currently stands, it feels like we could silently fail to enable something :(.
There was a problem hiding this comment.
I think if we do that, the cross-compiling CI would likely fail
There was a problem hiding this comment.
Hmm, why would it fail? The check should be for what host we are compiling for, not what the build is right?
This is disabled by default.
33168a0
to
cef5a5c
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is disabled by default.