[SSR v2] Fix unused imports from '@lwc/ssr-runtime'
#4793
Comments
|
This issue has been linked to a new work item: W-17152250 |
'@lwc/ssr-runtime'
|
@nolanlawson aren't the decorators always compiled away? |
|
@cardoso Rollup removes the unused imports in our unit tests, yeah. But on-core, these warnings turn into errors because we're much stricter. |
|
@nolanlawson I think that part I understand. I'm actually wondering if the fix here is simply removing the decorator imports during ssr. Or is there a case they're referenced at runtime? |
|
Well some of them haven't been implemented yet. 🙂 See #4807 for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In core, this Rollup warning is treated as an error:
This happens because sometimes we are sloppy about doing e.g.:
... in the output
.jsfiles from the@lwc/ssr-compiler, even thoughapimay be unused.We should clean this up and ensure that all of our imports are actually used.
The text was updated successfully, but these errors were encountered: