Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr-compiler): unused htmlEscape import #4804

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(ssr-compiler): unused htmlEscape import #4804

merged 1 commit into from
Nov 8, 2024

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Nov 7, 2024 •
edited
Loading

Details

Partially addresses #4793

'htmlEscape'

Before

  Snapshots  77 failed
 Test Files  1 failed | 3 passed (4)
      Tests  84 failed | 136 passed (220)

After

  Snapshots  38 failed
 Test Files  1 failed | 3 passed (4)
      Tests  45 failed | 175 passed (220)

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

@cardoso cardoso requested a review from a team as a code owner November 7, 2024 23:30
nolanlawson
nolanlawson approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@nolanlawson nolanlawson mentioned this pull request Nov 8, 2024
Closed
@nolanlawson
Copy link
Collaborator

/nucleus test

@nolanlawson nolanlawson enabled auto-merge (squash) November 8, 2024 20:51
@nolanlawson nolanlawson merged commit d013510 into salesforce:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanlawson nolanlawson nolanlawson approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardoso @nolanlawson