Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Replace NNBSP with standard space #7846

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[1.x] Replace NNBSP with standard space #7846

merged 2 commits into from
Oct 30, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 30, 2024 •
edited
Loading

Issue

Java 20 started to use NNBSP as space when formatting date. Probably due to some unknown JDK bug, NNBSP becomes garbled once outputted to terminal under certain conditions.

[success] Total time: 57 s, completed Oct 29, 2024, 5:38:13 p.m.

Solution

Replace NNBSP with standard space.

(Adapted from nodejs/node@492fc95bdf)

Closes #7558

@Friendseeker Friendseeker mentioned this pull request Oct 30, 2024
Closed
eed3si9n
eed3si9n reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself LGTM but could you add a comment explaining why we need this plz?

@Friendseeker Friendseeker mentioned this pull request Oct 30, 2024
Closed
eed3si9n
eed3si9n approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 94f239f into sbt:1.10.x Oct 30, 2024
10 checks passed
@Friendseeker Friendseeker deleted the bye-bye-nnbsp branch October 30, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sbt server displays weird characters around dates on Windows
2 participants
@Friendseeker @eed3si9n