Merge pull request #10900 from som-snytt/dogfood/unnamed-bool

Cleanup: lint boolean args
scala · Oct 27, 2024 · e32e565 · e32e565
2 parents cf5ded2 + 78a403c
commit e32e565
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/build.sbt b/build.sbt
@@ -208,7 +208,7 @@ lazy val commonSettings = instanceSettings ++ clearSourceAndResourceDirectories
     "-Wconf:cat=optimizer:is",
     // we use @nowarn for methods that are deprecated in JDK > 8, but CI/release is under JDK 8
     "-Wconf:cat=unused-nowarn:s",
-    //"-Wunnamed-boolean-literal-strict",
+    "-Wunnamed-boolean-literal-strict",
     ),
   Compile / doc / scalacOptions ++= Seq(
     "-doc-footer", "epfl",

diff --git a/src/compiler/scala/tools/nsc/typechecker/Implicits.scala b/src/compiler/scala/tools/nsc/typechecker/Implicits.scala
@@ -181,7 +181,7 @@ trait Implicits extends splain.SplainData {
     val tvars = tpars map (TypeVar untouchable _)
     val tpSubsted = tp.subst(tpars, tvars)
 
-    val search = new ImplicitSearch(EmptyTree, functionType(List(tpSubsted), AnyTpe), true, context.makeImplicit(reportAmbiguousErrors = false), isByNamePt = false)
+    val search = new ImplicitSearch(EmptyTree, functionType(List(tpSubsted), AnyTpe), isView = true, context.makeImplicit(reportAmbiguousErrors = false), isByNamePt = false)
 
     search.allImplicitsPoly(tvars)
   }

diff --git a/src/testkit/scala/tools/testkit/AllocationTest.scala b/src/testkit/scala/tools/testkit/AllocationTest.scala
@@ -57,7 +57,7 @@ object AllocationTest {
   }
 
   private def costOf[T](fn: => T, tpe: String): Long = {
-    val cost = coster.calcAllocationInfo(fn, 0, "", false).min
+    val cost = coster.calcAllocationInfo(fn, 0, "", ignoreEqualCheck = false).min
     println(s"cost of tracking allocations - cost of $tpe = $cost")
     cost
   }