Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cat alias detection to info.sh #911

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Conversation

eth-p
Copy link
Collaborator

@eth-p eth-p commented Apr 11, 2020

This should help in diagnosing issues when people have cat aliased to bat.

@sharkdp
Copy link
Owner

sharkdp commented Apr 11, 2020

Thank you for looking into this.

This does not detect aliases in zsh or bash. Only shell functions.

@eth-p
Copy link
Collaborator Author

eth-p commented Apr 12, 2020

Whoops. I thought I originally accounted for that when I wrote the previous version which this is based on. I'll work on a fix for that, sorry.

@eth-p
Copy link
Collaborator Author

eth-p commented Apr 21, 2020

Alias detection is now implemented. It tested it on bash, and I believe zsh acts similarly enough to bash that it should also work.

@sharkdp
Copy link
Owner

sharkdp commented Apr 21, 2020

Thank you. I can confirm that it works on zsh.

@sharkdp sharkdp merged commit 96aedf6 into sharkdp:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants