This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Add explicit compilation mode to compile-state-fn #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2022 07:04
Codecov Report
@@ Coverage Diff @@
## main #497 +/- ##
=======================================
Coverage 86.51% 86.52%
=======================================
Files 102 102
Lines 14576 14580 +4
Branches 768 770 +2
=======================================
+ Hits 12611 12615 +4
+ Misses 1197 1195 -2
- Partials 768 770 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit compilation mode to compile-state-fn #497:
sicmutils.expression.compile/compile-state-fnand its non-memoized versioncan now take an explicit
:modeargument; this will override thedynamically bound
*mode*.Invalid modes supplied via
:modewill causecompile-state-fnto throw anexception.
Fixes a bug where non-numeric operations
upanddownwere applied atcompile time, throwing an error.