This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Port curvature.scm, fix operator behavior #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 83.72% 83.63% -0.10%
==========================================
Files 84 85 +1
Lines 9659 9714 +55
Branches 501 497 -4
==========================================
+ Hits 8087 8124 +37
- Misses 1071 1093 +22
+ Partials 501 497 -4
Continue to review full report at Codecov.
|
24 tasks
added 3 commits
March 24, 2021 09:31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the CHANGELOG:
Port curvature.scm, fix operator behavior #337:
adds
sicmutils.calculus.curvature, with these new functions and many testsfrom the classic "Gravitation" book:
Riemann-curvature,Riemann,Ricci,torsion-vector,torsionandcurvature-componentsIf you combine
Operatorinstances with non-equal:subtypefields, thereturned operator now keeps the parent subtype (or throws if one is not a
subtype of the other).
Operatorinstances now ignore anyidentity?-passing operator on the leftor right side of operator-operator multiplication. Contexts are still
appropriately merged.
Similarly,
Operatoraddition ignoreszero?operators on the left orright side, and subtraction ignores
zero?operators on the right right.form fields now have NO identity operator, since they multiply by wedge, not
composition.