-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wayland: does not show window without a patch on newer electron versions #6368
Comments
Hello! Thanks for the heads up. The |
the problem seems to be that the pretty sure this only happens on electron 24 (and not on 23), while you still officially ship with electron 22, so I guess not |
Unfortunately I can't reproduce it locally. Are you trying it with a packaged app, or with |
to be more exact, are you sure you're using electron24, and then also perhaps on wayland (--ozone-platform-hint=wayland, not sure if it's relevant) if not, then it's not reproducible, as this was not a bug with 23. |
Yup, I'm on 24.1.0, but testing on macOS and Ubuntu VM in github actions. I have a feeling that actions VM is not using wayland because we don't pass this argument. Can you reproduce this issue with just electron fiddle alone? Might be worth reporting to Electron! |
yeah, sounds more related to electron in this environment then, unless there is a very good other reason the ready-to-show event is never emitted. thanks for checking! |
@selfisekai Did you get Signal to work with electron 23? I recall it showing an error box on startup when i tried and that's why i delayed 23 in openSUSE. |
@brjsp we did not try |
We'll be releasing a beta version based on Electron 24 soon; we'll see if that works for you. |
Newly released 6.19.0 (which uses Electron 24.3.0) doesn't work with Wayland for me (Debian bookworm amd64), even though running |
@roubert Can you tell us more about your configuration? A debug log would help as well! |
I have a fairly standard Debian bookworm amd64 installation, using the default GNOME desktop enviroment on Wayland, with the only obvious non-standard thing being this additional As the GUI never opens, I can't use the Debug Log / Submit feature, but I've now sent my logs per mail to support@signal.org as described here: https://support.signal.org/hc/en-us/articles/360007318591-Debug-Logs-and-Crash-Reports |
You can get a debug log straight from disk at |
Yes, that is exactly what I did, just as described in that support page I linked to. |
I've now updated to newly released 6.20.0 (which also uses Electron 24.3.0) and the problem persists (just as expected). |
I think this ticket should be reopened. 6.20.1 still doesn't show a window under Wayland with Signal from Arch Linux's package or the deb from updates.signal.org. Forced to run 6.18.1. |
Is Wayland supported/tested or should we expect issues? |
Still broken in 6.22.0 |
Could you try 6.23.0-beta.1 ? It is on Electron 25. |
Sure, but still no visible window with 6.23.0-beta.1, sorry. |
I don't know whether Wayland is officially supported by Signal, but I also don't think that matters very much for this issue as more and more distros are switching to Wayland as the default and running Signal on native Wayland was something that used to work until the Signal 6.19.0 release and is something that will need to work again in the future. |
It's also normal for even 6.18.1 to require multiple attempts until Signal starts without immediately crashing (#6247, #6260). When it doesn't crash immediately, it sometimes crashes when you start signal and send a message without waiting. Once it's been up for a minute or two, it's stable, so that's good. |
@selfisekai this is probably a gtk/sway mismatch of the wayland protocols and what is expected, i.e. https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/150 if you built the qt5 shim for electron (assuming it supports it like chromium) and passed |
As the bug persists, can we reopen the ticket? |
@scottnonnenberg-signal what do you think about adding |
With the release of GNOME 45 this issue has suddenly become more important than it was before, as this release enables fractional scaling by default, which causes XWayland windows to appear a bit blurry, while native Wayland windows appear sharp (and correctly scaled), thereby making the ability to run Signal as native Wayland a much more important feature for many users from now on. |
Though, this is still broken: signalapp/Signal-Desktop#6368
Thanks! That also did the trick for me. |
Also in Arch w/Wayland: Signal works under xwayland. Edit: |
@scottnonnenberg-signal is it possible that this incorrectly labeled? "Upstream Change Needed" seems incorrect as from what I read here, we've not entirely determined why ready-to-show is not being sent/received. The xdg-activation issue is about clarification and the protocol itself seems to be primarily about focus and activation. The Is it possible to look into this issue again so we can get Signal running on Wayland? Perhaps the labels "Linux", "Wayland", and "Bug" more clearly indicate the scope of the issue. |
Hi all, sorry for the issues you've been experiencing on Wayland. Appreciate all the work people have done on investigation and workarounds. I'm running Debian + Wayland + Gnome and can confirm the bug -- the window doesn't show when running the app with either @AndreasBackx Thank you for clarification and suggestions, I've updated the labels. |
@ayumi-signal thank you for the quick reply! It seems like the label changes haven't gone through on my end. Could you have a second look? |
Experiencing the same issue as #6368 (comment), both with "signal-desktop-fix-sway" and normal signal-desktop. Error message: |
For me it’s vice versa. Edit: Adding |
I'm experiencing the same issue as everyone, running it once in the terminal and a second time works fine, the window pops up. To add to the confusion, I noticed that if I run signal-desktop using firejail, the window shows up on the first run. When run through firejail, I have the following error in the terminal:
(It seems this error is emitted by the chromium sandbox) I don't know anything about the inner working of Electron or how it interacts with the chromium sandbox, and maybe that error is not related at all, but could it be that Electron is waiting for a DBUS message that it never receives ? Hence the fact that it runs fine through firejail because apparently its access to DBUS is denied (and therefore probably fallback to another behavior). I use Arch btw |
The issue has recently resurfaced for me as an Arch Linux user with an Nvidia GPU. My installation includes:
The issue appeared for me a month ago. Before that everything was working fine, albeit with visual artifacts, like flickering. I can't say, which update broke everything. If I were to bet, I would say it was Nvidia driver, which is constantly causing similar problems. I managed to get Signal working "properly", i.e., without crashes or missing visual content. I am leaving the instructions (that were already mentioned above) in a single comment, so that other people encountering the same problem could spare their time reading the whole thread. I did the following:
|
@mkmaslov The |
You machine might not have an issue, but I can confirm it's not a NVIDIA only issue. I have an intel GPU, and the window doesn't appear under wayland, like described here above in this issue:
I am running arch with signal-desktop package 7.6.0-1 (signal desktop 7.6.0). I am resolving the issue by running the command twice. |
Hey, I have the same issue on NixOS with v7.11.1. Running under Wayland I need to execute the The first instance keeps running but does not launch a window. The second call logs some stuff and instantly closes, while the first instance now opens a window. No issues on XWayland. Second run logs
|
After upgrading to GNOME 46 today I thought revisiting this issue might be a good idea and it's still broken (still in the same way) with current Signal Desktop 7.17.0 and the trick of executing |
I'm on an Intel iGPU under Arch Linux and Sway. I have ELECTRON_OZONE_PLATFORM_HINT set to auto. Installing signal-desktop-fix-sway from the AUR worked for me. I wasn't experiencing this issue before in Hyprland where I have the same environment variable set, but I haven't tried recently. I usually use the flatpak package. |
Issue also happening on AMD CPU + integrated GPU. Was using a
Enabling Using Just sad that |
Hello, you don't need to use your script to enable wayland support. you can use this env var |
This works but has the same problem of not showing a window on the first startup (and the window icon in GNOME activity overview being wrong). |
Yes I know. I said "to enable wayland support". unrelated to the issue. |
just a heads-up for you. I'm the maintainer of the signal-desktop package in alpine linux.
coincidentally 2 things happened at once, so I'm not sure which one was the problem, but I'm guessing the former:
with both these changes, the window of signal-desktop stopped appearing for me.
it shows correctly with this patch:
log: https://s3.sakamoto.pl/lnl-shit/Ad6QacHk03dQ.txt
The text was updated successfully, but these errors were encountered: