Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contexture #1727

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Add Contexture #1727

merged 2 commits into from
Mar 9, 2020

Conversation

chrislatorres
Copy link
Contributor

@chrislatorres chrislatorres commented Mar 8, 2020

https://github.com/softwarebycl/awesome-contexture

This awesome list covers the best and the brightest of the Contexture ecosystem. Contexture is used for abstracting queries/filters and results/aggregrations from different backing data stores like ElasticSearch and MongoDB.

This list includes the best applications, libraries, documentation, and other resources from the Contexture ecosystem. It is a great way for the community to see the best of Contexture in one place and to be able to contribute to the growing ecosystem.

Reviewed PRs:
#1725 (comment)
#1722 (comment)
#1728 (comment)
#1721 (comment)
#1720 (comment)
#1703 (comment)
#1701 (comment)
#1699 (comment)
#1679 (comment)
#1676 (comment)
#1666 (comment)
#1660 (comment)
#1622 (comment)

Passed awesome-lint.

By submitting this pull request I confirm I've read and complied with the requirements 🖖

@chrislatorres
Copy link
Contributor Author

unicorn

@simskij
Copy link
Contributor

simskij commented Mar 8, 2020

image

This is only my opinion of course, but the top section really looks awful as it is structured currently. Given the size of your image, I'd suggest you place it centered over the level 1 header.

I also think that you might gone a bit overboard with the description. Would it be possible to condense it and link to a more lengthy description?

@chrislatorres
Copy link
Contributor Author

chrislatorres commented Mar 8, 2020

Thanks @simskij, I will try to condense the description and try the different image placement.

edit: done

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@chrislatorres
Copy link
Contributor Author

Thanks @sindresorhus, fixed!

@sindresorhus
Copy link
Owner

Not sure why you removed the linkified word here, but that should stay.

@chrislatorres
Copy link
Contributor Author

Not sure why you removed the linkified word here, but that should stay.

Fixed.

@sindresorhus
Copy link
Owner

Also use proper commit titles in your repo. Update readme.md is quite useless (and noisy) when looking at the commit history.

@chrislatorres
Copy link
Contributor Author

Thanks @sindresorhus, I agree that was bad practice.

Updated the commit messages to be more useful.

@sindresorhus sindresorhus merged commit b833991 into sindresorhus:master Mar 9, 2020
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1237011247087808512

@sindresorhus
Copy link
Owner

I would just squash all the commits into one commit as they're not really useful.

DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants