Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove branches key from branch_protection_rule #49

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

sinsukehlab
Copy link
Contributor

This PR is suggested (commit) and generated (description except for this part and the link to the issue) by GitHub Copilot Chat.

Summary

This pull request addresses an issue in the 4-add-branch-protections.yml GitHub Actions workflow file. The branches key was incorrectly placed under the branch_protection_rule key, which is not valid syntax.

Changes

The branches key has been removed from under the branch_protection_rule key in the 4-add-branch-protections.yml file. This corrects the workflow syntax and ensures the workflow triggers correctly when a branch protection rule is created or edited.

Closes: #34

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@cmwilson21
Copy link
Contributor

👋 @sinsukehlab Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added the needs engineering Requires engineering-specific changes only. label Nov 14, 2023
@cmwilson21 cmwilson21 requested a review from a team November 14, 2023 16:55
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@heiskr heiskr merged commit a8b85f3 into skills:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering-specific changes only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] branch_protection_rule trigger has an unexpected value
3 participants