Fix inaccurate item name in README #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinsukehlab
reviewed
Dec 9, 2022
| @@ -195,7 +195,7 @@ Protected branches ensure that collaborators on your repository cannot make irre | |||
| 1. Go to **Branches** settings. You can navigate to that page manually by clicking on the right-most tab in the top of the repository called **Settings** and then clicking on **Branches**. | |||
| 1. Click on **Add rule** under "Branch protection rules". | |||
| 1. Type `main` in **Branch name pattern**. | |||
| 1. Check **Require pull request reviews before merging**. | |||
| 1. Check **Require a pull request before merging**. | |||
There was a problem hiding this comment.
Cf. #14
Suggested change
| 1. Check **Require a pull request before merging**. | |
| 1. Check **Require a pull request before merging**. | |
| 1. Uncheck **Require approvals**. |
There was a problem hiding this comment.
Also, I wonder if l. 200 is necessary.
|
I'll go ahead and merge this as is, I've internally requested an instructional designer to review this course given the comments on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This PR intends to fix an inaccurate item name.
What's being changed:
Step4 in README.
Description of the item name on the screen to be checked in step 4 .
Check off the following: