Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset step back to 0 #13

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Reset step back to 0 #13

merged 4 commits into from
Aug 11, 2022

Conversation

a-a-ron
Copy link
Contributor

@a-a-ron a-a-ron commented Aug 11, 2022

Why:

Closes [issue link]

What's being changed:

This PR fixes the following:

  • Updates the step count error and sets it from 3 to 0
  • Replaces .github/script/update-step.sh with the recommended skills/action-update-step@v1
  • Updates incorrect keyword to close the issue in step 3

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@a-a-ron a-a-ron requested a review from heiskr August 11, 2022 17:31
@a-a-ron a-a-ron self-assigned this Aug 11, 2022
@heiskr heiskr merged commit ee6a744 into main Aug 11, 2022
@heiskr heiskr deleted the as-updates branch August 11, 2022 18:01
@sinsukehlab sinsukehlab mentioned this pull request Aug 12, 2022
2 tasks
sinsukehlab added a commit to sinsukehlab/connect-the-dots that referenced this pull request Aug 12, 2022
@sinsukehlab
Copy link
Contributor

Indeed a-a-ron/connect-dots-test seems to function well, but actually does not function as expected.

heiskr pushed a commit that referenced this pull request Aug 25, 2022
* Revert "Update to 3 in STEP and README.md"

This reverts commit 6cabd6b.

* Revert "Update to 2 in STEP and README.md"

This reverts commit 941db4d.

* Revert "Update to 1 in STEP and README.md"

This reverts commit b313566.

* Revert "created SIDEBARCOMMIT"

This reverts commit 97cd10a.

* Revert "add sidebar to documentation"

This reverts commit 9b04198.

* Revert "updated _sidebar.md"

This reverts commit a1093f3.

* Update update-step.sh

Add commands to edit HTML comments

* Update workflows

Make actions run unless the repository is template

* Fix workflows (minor changes)

A minor change in 0-start.yml corresponds to an update on update-step.sh

* Use skills/action-update-step@v1

Complement of #13

* Change trigger in 0-start.yml

on:
  workflow_dispatch:
  push:
    branches:
      - main

* Fix action-update-step env variables

.github/workflows/ Remove branch_name

(Minor) Clarify instructions in README.md Step 3

* Fix a check in 3-fix-broken-sidebar.yml

Found _Closes_ message

* Remove a redundant if

* Fix some checks in Steps 2 and 3

contains(,)

* Change the trigger for 3-fix-broken-sidebar.yml

Now the trigger is on issue_comment

Also fix YAML style for multi-line conditinal expressions (#14)

Fix some 'TBD' comments

* Use single-line conditional expressions

Cf. #14

Also change the trigger for 3-fix-broken-sidebar.yml

* Clearly indicate the wait in README.md

Also use X for the last step instead of 4

* Enable echoing of workflow commands

::echo::on

* Fix 3-fix-broken-sidebar.yml comments

Minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants