Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 'command not found' error: Step 4 #106

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fixing 'command not found' error: Step 4 #106

merged 2 commits into from
Jul 15, 2024

Conversation

rustedredswitch
Copy link
Contributor

@rustedredswitch rustedredswitch commented Jul 12, 2024

Summary

I want fix these bug: bash: sl: command not found partialy reported in this issue: #98.

Changes

I didn't have problem with the installation of sl with apt-get, but I notice that the environment variable /usr/games are not included when I try to run echo $PATH.
In my commit, I changed the setup.sh code. Now, /usr/games is added to the original PATH variable and it's saved in the ~/.bashrc file. This allows you to have the new variable in all open terminals. Therefore, when you try to run the sl command, the script starts without errors, allowing you to complete Step 4. 🎉

Link to Issue 98

Closes

Hoping that you like this contribution, I wanted to thank you for this exercise, which introduced me to the world of codespaces.
If you have any doubts, please do not hesitate to contact me.
Have a nice day,
Alessandro

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@rustedredswitch rustedredswitch changed the title fixing path file Fixing No such file or directory Jul 12, 2024
@rustedredswitch rustedredswitch changed the title Fixing No such file or directory Fixing 'command not found' error Jul 15, 2024
@rustedredswitch rustedredswitch changed the title Fixing 'command not found' error Fixing 'command not found' error, Step 4 Jul 15, 2024
@rustedredswitch rustedredswitch changed the title Fixing 'command not found' error, Step 4 Fixing 'command not found' error: Step 4 Jul 15, 2024
Copy link
Contributor

@sinsukehlab sinsukehlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was forgetting that the export command should be coded in the .bashrc file to change the environment variable when a codespace is created.
Thank you for submitting this PR.

.github/steps/4-personalize-codespace.md Outdated Show resolved Hide resolved
Co-authored-by: Shinsuke Higashiyama aka Cinzeng Zia <94058150+sinsukehlab@users.noreply.github.com>
@hectorsector
Copy link
Contributor

❇️ Thanks so much for the contribution, @rustedredswitch @sinsukehlab ❤️. Closes #98.

@hectorsector hectorsector merged commit 680bcfb into skills:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants