Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong text fragment #27

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Remove wrong text fragment #27

merged 1 commit into from
Feb 15, 2023

Conversation

bpires
Copy link
Contributor

@bpires bpires commented Nov 21, 2022

Why:

Closes #26

What's being changed:

I'm removing a text fragment that can cause confusion to learners.

Before:

Your new action will run any time a new commit is created or pushed to the remote repository. Since 
you just created a commit, the workflow should have been triggered.

After:

Your new action will run any time a new pull request has been opened.

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@heiskr heiskr requested a review from a team November 26, 2022 18:02
@chadfawcett
Copy link
Contributor

@heiskr I think this can be merged in. Can you confirm?

@heiskr
Copy link
Contributor

heiskr commented Feb 15, 2023

I'll go ahead and merge, but @skills/content-reviewers feel free to make edits if needed.

@heiskr heiskr merged commit a2d9219 into skills:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinsukehlab sinsukehlab sinsukehlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] wrong text fragment on README.md | Step 5: Trigger the workflow | related to #6
4 participants
@bpires @chadfawcett @heiskr @sinsukehlab