Ask learner to create PR manually and add permissions
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PR is created _after_ the workflow is created, then the `welcome` workflow will run and comment on this PR which might add some confusion and renders the test PR in step 5 redundant.
In order to leave a comment on a PR, the workflow needs the `pull-requests: write` permission.
heiskr
approved these changes
Feb 15, 2023
heiskr
reviewed
Feb 15, 2023
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Relates to https://github.com/github/skills/issues/96
The GITHUB_TOKEN we use in the Actions workflows no longer allows the creation of PRs.
What's being changed:
permissionfield to the workflow code snippet in the course so the workflow has permission to comment on the PR. I think this would be better as a separate step to the course, but I tried to change as little as possible for this PR.Check off the following: