-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Skills course for Actions #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the course easier to follow after your changes. A couple of minor thoughts, but otherwise 👍🏻
.github/steps/1-create-a-workflow.md
Outdated
|
||
1. To commit your changes, click **Commit changes**. | ||
1. Type a commit message, select **Commit directly to the welcome-workflow branch** and click **Commit changes**. | ||
1. Wait about 20 seconds, then refresh this page (the one you're following instructions from). A separate Actions workflow in the repository (not the workflow you created) will run and will automatically replace this content with instructions for the next step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should mention that this is the README
file?
.github/steps/2-add-a-job.md
Outdated
2. Update the contents of the file to: | ||
```yaml | ||
1. In a separate browser tab, make sure you are on the `welcome-workflow` branch and open your `.github/workflows/welcome.yml` file. | ||
1. Update the contents of the file to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mention editing the file, or is that obvious to the expected audience?
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
I worked through the Skills course for Actions and made a few changes while I was doing this.
Changes
Changes to clarify some instructions and add a few missing steps.
First part of: https://github.com/github/docs-content/issues/14220
Previews
Task list