Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace em dash with en dash (or vise versa) #8

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

davebunte
Copy link
Contributor

@davebunte davebunte commented Jun 9, 2022

The original - in the word private-repositories was creating a false positive in the detection action and causing the workflow to fail. Replacing that dash with the "standard" one caused that error to go away and allow the action to resolve successfully. The better solution might be to adjust the emoji checking script (perhaps something similar to the solution described in this Slack Overflow post).

Why:

Workaround for #7

What's being changed:

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

The original `-` in the word `private-repositories` was creating a false positive in the detection action and causing the workflow to fail. Replacing that dash with the "standard" one caused that error to go away and allow the action to resolve successfully
@davebunte davebunte requested a review from heiskr June 9, 2022 18:40
@heiskr heiskr merged commit b054b96 into main Jun 9, 2022
@heiskr heiskr deleted the davebunte-patch-1 branch June 9, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants