Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note #450

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Note #450

merged 3 commits into from
Mar 19, 2024

Conversation

sinsukehlab
Copy link
Contributor

@sinsukehlab sinsukehlab commented Jul 21, 2023

Summary

**Note**[!NOTE]

Changes

The GFM highlighting syntax has recently been updated. I have replaced the Note highlights.

Example use

> [!NOTE]
> This is a note.

How it is displayed:

Note

This is a note.

Discussed in https://github.com/orgs/skills/discussions/305

Originally posted by sinsukehlab July 21, 2023
An option to highlight a "Note" and "Warning" is updated.
I will open PRs to apply this change to the courses.

See: https://github.com/orgs/community/discussions/16925#discussioncomment-6506860

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

> [!NOTE]
> New syntax introduced by @dipree
> [!NOTE]\
> Line break with `\`
@heiskr heiskr requested a review from a team July 24, 2023 17:28
@cmwilson21
Copy link
Contributor

@sinsukehlab Thanks for submitting a PR! But let's hold off on incorporating this throughout Skills. Per that discussion, there are some changes still happening. We will keep an eye on it, though! 👀

Soft line breaks will now suffice.
This reverts commit 4153bdf.
@Aishwary-Gathe

This comment was marked as spam.

@Cuengpribadi

This comment was marked as spam.

@indivisiblefoundation
Copy link

changes perform automatically

@dhruvp66572
Copy link

Note

Copy link

@edwinbermudez edwinbermudez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval

@sinsukehlab
Copy link
Contributor Author

Recent update has just broken everything. 😬
I will close this PR unless the feature is restored.

Update - 14 November 2023

  • Add support for [!TIP] and [!CAUTION].
  • Add support for alerts in Markdown files on GitHub Mobile apps. (pending a mobile app update)
  • Add support for various Markdown extensions such as Math rendering, relative links, task lists, animated image player and footnotes.
  • Prevent alerts from being nested within other elements.
  • The initial syntax using e.g. **Note** isn't supported any longer.

@Faphouse

This comment was marked as spam.

@Faphouse

This comment was marked as spam.

@RalphMaas
Copy link

Oke

@Sw33tDisasteR
Copy link

Thanks a lot!

Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it still doesn't show up in preview or in viewing the repo, yet when I play in this repo it renders correctly. Im going to go ahead and merge and hopefully it works.

@heiskr heiskr merged commit ad36a6f into skills:main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.