Skills secret scanning course: text updates to adjust for a few changes since the course was created and for consistency #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
commented
Apr 23, 2024
leftrightleft
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Thank you so much @felicitymay! These are very solid suggestions. I added a couple suggested edits to the wording, but all in all a great update!
Co-authored-by: Dan Shanahan <leftrightleft@github.com>
|
Many thanks for the quick turnaround on the review and the great suggestions. In addition to committing your changes, I've added a tip for command-line users with a link to the help. |
|
Why didn't you select the Squash and merge option when you merged the PR? |
|
Oh, PRs aren't squashed in this repo like in other skills repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It started with a typo "serets" and then continued with small text updates to bring this closer to the Docs style guide and to account for the fact that you don't need to enable either feature if you've created a public repository, as suggested.
Changes
I'm going to add comments to the places where I made changes to the sense of the text as I think this will be easier to follow.
Since this is a "drive-by PR", I'm very happy to discuss any of the changes I've suggested and revert anything that we agree should remain as-is.
Previews
Task list