Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask learner to create PR manually and add permissions #18

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Ask learner to create PR manually and add permissions #18

merged 4 commits into from
Feb 16, 2023

Conversation

chadfawcett
Copy link
Contributor

Why:

Relates to https://github.com/github/skills/issues/96

The GITHUB_TOKEN we use in the Actions workflows no longer allows the creation of PRs.

What's being changed:

  • Updating the course to remove any automatically-generated PRs. The learner is now asked to create any necessary PRs.
  • Adds the permissions field to the workflow code snippet in the course so the workflow has permission to publish the package.

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@chadfawcett chadfawcett requested review from a team February 16, 2023 02:38
heiskr
heiskr approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@heiskr heiskr merged commit 7e3731f into skills:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadfawcett @heiskr