Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the publish.yml template #19

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Update the publish.yml template #19

merged 3 commits into from
Feb 24, 2023

Conversation

sinsukehlab
Copy link
Contributor

metadata-action

Why:

Closes #17

What's being changed:

  • Bump actions/checkout to v3 (already done in 2459f17)
  • Add a docker/metadata-action@v4 step
  • Add a docker/login-action@v2 step
  • Bump docker/build-push-action to v3

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

This was referenced Feb 21, 2023
Closed
Merged
chadfawcett
chadfawcett reviewed Feb 21, 2023
View reviewed changes
README.md Show resolved Hide resolved
@chadfawcett
Copy link
Contributor

@heiskr can you give this a review?

heiskr
heiskr approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks gravy to me :) Thanks!

@heiskr heiskr merged commit 363a4ec into skills:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

@chadfawcett chadfawcett Awaiting requested review from chadfawcett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Using deprecated input for docker/build-push-action@v1
3 participants
@sinsukehlab @chadfawcett @heiskr