Change the base image in Dockerfile block (nginx:1.17 to nginx:1.24-alpine) #22

sinsukehlab · 2023-04-25T06:04:51Z

Why:

nginx:1.17 is vulnerable.

What's being changed:

README.md

comment: CC-BY 4.0 → MIT
Dockerfile block: nginx:1.17 → nginx:1.24-alpine
Add -p 8080:80 to the docker run command

2-add-a-dockerfile.yml

Verify Dockerfile contents: nginx:1.17 → nginx:1.24-alpine

Check off the following:

For workflow changes, I have verified the Actions workflows function as expected.
For content changes, I have reviewed the style guide.

nginx:1.24-alpine

docker run -dp 8080:80

hectorsector

Thanks for making the update @sinsukehlab! We'll also need to update the workflow for step 2 (see below) as it validates the contents of Dockerfile.

To test your changes after you do this, you can:

Create a new repository
Push from your branch to the new repository's main branch
Run through the course in the new repository

These steps should flag any remaining problems with the changes.

publish-packages/.github/workflows/2-add-a-dockerfile.yml

Lines 61 to 66 in 530a46e

    
           # Check the learner added intended contents to the file 
        
           - name: Verify Dockerfile contents 
        
             run: ./.github/script/check-file.sh 
        
             env: 
        
               FILE: "Dockerfile" 
        
               SEARCH: "FROM nginx:1.17"

Verify Dockerfile contents

sinsukehlab · 2023-04-27T06:46:11Z

I have updated the workflow for Step 2.

sinsukehlab · 2023-05-01T07:16:53Z

The workflow verified
https://github.com/sinsukehlab/publish-packages-sinsukehlab/actions/runs/4817443439

cmwilson21 · 2023-05-02T16:11:15Z

@sinsukehlab Thanks for the verification! I'll take a look at this from the content side ✨

README.md

cmwilson21 · 2023-05-09T21:26:31Z

@sinsukehlab 👋 - Just added a few minor content edits 👍

Let me know if you accept them and I'll get this merged ✅

Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>

example of running the docker command listed above Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>

Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>

sinsukehlab · 2023-05-11T05:13:55Z

@cmwilson21 Thanks for adding the edits. I have accepted them.

cmwilson21

LGTM! Thanks for the updates! 🎉

sinsukehlab · 2023-05-23T06:20:40Z

@cmwilson21 @hectorsector gentle reminder

hectorsector

Thanks for your patience @sinsukehlab!

sinsukehlab added 5 commits April 25, 2023 13:54

Change a comment on the license

7ee00dc

Add an instruction to Step 1

3d7f43b

Change the base image in Dockerfile block

548579e

nginx:1.24-alpine

Edit Step 4

a2bd114

Edit Step 5

223a4b6

docker run -dp 8080:80

sinsukehlab changed the title ~~Docker block~~ Change the base image in Dockerfile block (nginx:1.17 to nginx:1.24-alpine) Apr 25, 2023

Add a period

3b075ee

sinsukehlab mentioned this pull request Apr 25, 2023

Fix README.md #7

Merged

2 tasks

Year 2023

6e56dc7

hectorsector requested changes Apr 25, 2023

View reviewed changes

Update the workflow for Step 2

14dbc42

Verify Dockerfile contents

sinsukehlab requested a review from hectorsector April 27, 2023 06:46

cmwilson21 self-requested a review May 2, 2023 16:09

cmwilson21 self-assigned this May 2, 2023

cmwilson21 reviewed May 9, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

cmwilson21 reviewed May 9, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

cmwilson21 reviewed May 9, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

sinsukehlab and others added 3 commits May 11, 2023 13:25

Trim down an instruction

0c7fbfb

Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>

Remove a screenshot

eaf73f6

example of running the docker command listed above Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>

Edit punctuation

5dff61d

Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>

cmwilson21 approved these changes May 11, 2023

View reviewed changes

hectorsector approved these changes May 23, 2023

View reviewed changes

hectorsector merged commit e3a587e into skills:main May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the base image in Dockerfile block (nginx:1.17 to nginx:1.24-alpine) #22

Change the base image in Dockerfile block (nginx:1.17 to nginx:1.24-alpine) #22

sinsukehlab commented Apr 25, 2023 •

edited

Loading

hectorsector left a comment

sinsukehlab commented Apr 27, 2023

sinsukehlab commented May 1, 2023

cmwilson21 commented May 2, 2023

cmwilson21 commented May 9, 2023

sinsukehlab commented May 11, 2023

cmwilson21 left a comment

sinsukehlab commented May 23, 2023

hectorsector left a comment

	# Check the learner added intended contents to the file
	- name: Verify Dockerfile contents
	run: ./.github/script/check-file.sh
	env:
	FILE: "Dockerfile"
	SEARCH: "FROM nginx:1.17"

Change the base image in Dockerfile block (nginx:1.17 to nginx:1.24-alpine) #22

Change the base image in Dockerfile block (nginx:1.17 to nginx:1.24-alpine) #22

Conversation

sinsukehlab commented Apr 25, 2023 • edited Loading

Why:

What's being changed:

Check off the following:

hectorsector left a comment

Choose a reason for hiding this comment

sinsukehlab commented Apr 27, 2023

sinsukehlab commented May 1, 2023

cmwilson21 commented May 2, 2023

cmwilson21 commented May 9, 2023

sinsukehlab commented May 11, 2023

cmwilson21 left a comment

Choose a reason for hiding this comment

sinsukehlab commented May 23, 2023

hectorsector left a comment

Choose a reason for hiding this comment

sinsukehlab commented Apr 25, 2023 •

edited

Loading