Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared update-step action #26

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

sinsukehlab
Copy link
Contributor

skills/action-update-step

Summary

"TODO UPDATE" of #25
⚠️ skills/action-update-step#14 should be merged and released before.

Changes

Delete the custom step and use shared update-step action.
The action skills/action-update-step with to_step: 45X will update -step.txt to "45X", and README.md body to the Steps 4, 5 and X concatenated in the course.

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

skills/action-update-step
@cmwilson21
Copy link
Contributor

👋 @sinsukehlab Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added the engineering Engineering review needed label Jun 7, 2023
@hectorsector hectorsector requested a review from a team June 12, 2023 13:41
@heiskr heiskr merged commit f51678f into skills:main Jun 12, 2023
@sinsukehlab
Copy link
Contributor Author

@cmwilson21 @hectorsector @heiskr The course will need skills/action-update-step@2.1.0 (skills/action-update-step#14) with this PR merged. The current action-update-step (skills/action-update-step@2.0.0) will just try to show 45X-*.md (no such files). Please review and merge the PR skills/action-update-step#14 as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Engineering review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants