Fix issues #54 and #53 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues #53 and #54 in a manner that complies with the original specification for the Season 1/Level 1 problem. The proposed changes are not over engineered to retain focus on the main bug.
Changes
tests.pytest_4that ensures that invalid data will not blow up a systemAdded
test_5that was missing to properly check for invalid item typehack.pyAdded
test_8that checks for the maximum amount on an order using a correct order validation logicsolution.pyMade the code more pythonic regarding testing for range of values
Added an extra paragraph to the explanation section about the importance to check for data types
Closes:
Task list