Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #55 #58

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix issue #55 #58

merged 2 commits into from
Jan 5, 2024

Conversation

evarga
Copy link
Contributor

@evarga evarga commented Jan 1, 2024

Summary

This PR contains the fix for issue #55 in a manner that still retains the original focus on the buffer overflow problem whilst also introducing an another concept security through obscurity and it's associated vulnerability.

Changes

All files have been modified, since the API was altered to hide the low implementation details from users. In this case the user_account structure. There are numerous comments in the source code informing the learner about the content. The solution.c contains a detailed explanation why handing over raw structures to a user is a bad idea from a security standpoint.

Nonetheless, if the only security measure is about hiding implementation facts, then an attacker can reverse engineer the code and exploit vulnerabilities. This is emphasized in this new version of the code base. In this way, it would be even more understandable for a learner why checking input is indispensable in security engineering.

P.S. The hint.txt has been split into two files hint-1.txt and hint-2.txt each having one hint.

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@rsese rsese requested a review from a team January 2, 2024 17:12
@jkcso jkcso self-assigned this Jan 4, 2024
@jkcso jkcso merged commit 6a89fdc into skills:main Jan 5, 2024
4 checks passed
@evarga evarga deleted the fix--season-1--level-2 branch January 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants