go-vshard-1: init golang vshard library #470
Conversation
|
Seems legit |
|
we found more productive hardware and got more interesting bench results, unfortunately without tarantool-vshard-proxy for now. We haven't been able to overclock it to the maximum yet and the rps is too small, we're trying to get the maximum more details https://github.com/KaymeKaydex/go-vhsard-router |
There was a problem hiding this comment.
Hi! Thanks for the nice patch! Looks amazing that it doesn't seem too big and yet works fine, from what I see. I couldn't find any errors here, and the code looks mostly the same as the Lua router, which is cool.
I can't judge the Go specific places though, since I don't know it well. Also to the 'todo' in vshard.go file in the end - you don't really need them I think. Those are crutches specific for tarantool runtime. In your router they don't seem needed.
However regardless of how cool the patch is, I can't really merge it, sorry. It looks out of place, at least without proper testing infrastructure, CI, and lots lots of tests. We only have Lua and C test runners, unfortunately.
since the tarantool router is a stateless application, we did a small implementation of the router in golang, we did several performance tests that showed positive results
in the case of the router, we took resources from the golang service and gave them to tarntool routers
the library allows you to avoid unnecessary network trips and speed up the route map update due to golang runtime
; now we use https://github.com/KaymeKaydex/go-vhsard-router but we want to get official support
we want to hear some feedback on this topic and review, now there are several non-critical todos, as well as an unfinished readme. Before finishing I would like to know your opinion and feedback
new topology scheme:
