Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: csv stream import get error character #560

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: csv stream import get error character #560

merged 1 commit into from
Apr 10, 2024

Conversation

caoxing9
Copy link
Contributor

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Apr 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8630383653

Details

  • 126 of 134 (94.03%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+62.3%) to 82.643%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/import/open-api/delimiter-stream.ts 111 114 97.37%
apps/nestjs-backend/src/features/import/open-api/import.class.ts 15 20 75.0%
Totals Coverage Status
Change from base Build 8628661395: 62.3%
Covered Lines: 27173
Relevant Lines: 32880
💛 - Coveralls

@caoxing9 caoxing9 marked this pull request as draft April 10, 2024 10:54
@caoxing9 caoxing9 force-pushed the fix/csv-stream-import-character-error branch from 2057e74 to f1161e7 Compare April 10, 2024 11:20
@caoxing9 caoxing9 marked this pull request as ready for review April 10, 2024 11:25
@tea-artist tea-artist merged commit 8472da7 into develop Apr 10, 2024
6 checks passed
@tea-artist tea-artist deleted the fix/csv-stream-import-character-error branch April 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caoxing9 @coveralls @tea-artist