Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: created by and last modified by field #816

Merged
merged 3 commits into from
Aug 13, 2024
Merged

feat: created by and last modified by field #816

merged 3 commits into from
Aug 13, 2024

Conversation

tea-artist
Copy link
Contributor

Add two new field

  1. created by
  2. last modified by

related issue #589

@tea-artist tea-artist linked an issue Aug 13, 2024 that may be closed by this pull request
[Feature Request] Last Updated By field #589
Closed
@tea-artist tea-artist requested review from boris-w and Sky-FE and removed request for boris-w August 13, 2024 07:32
@coveralls
Copy link
Collaborator

coveralls commented Aug 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10366031796

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 278 of 299 (92.98%) changed or added relevant lines in 20 files are covered.
  • 36 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 82.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/share/share.service.ts 6 7 85.71%
apps/nestjs-backend/src/db-provider/sort-query/postgres/multiple-value/multiple-json-sort.adapter.ts 3 5 60.0%
apps/nestjs-backend/src/features/field/field-calculate/field-supplement.service.ts 32 34 94.12%
apps/nestjs-backend/src/features/field/model/field-dto/last-modified-by-field.dto.ts 36 39 92.31%
apps/nestjs-backend/src/db-provider/sort-query/postgres/single-value/json-sort.adapter.ts 1 5 20.0%
apps/nestjs-backend/src/db-provider/sort-query/sqlite/single-value/json-sort.adapter.ts 1 5 20.0%
apps/nestjs-backend/src/features/field/model/field-dto/created-by-field.dto.ts 34 39 87.18%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/share/share.service.ts 1 84.53%
apps/nestjs-backend/src/features/base/base.service.ts 35 49.39%
Totals Coverage Status
Change from base Build 10348436149: 0.3%
Covered Lines: 29605
Relevant Lines: 35687
💛 - Coveralls

@tea-artist tea-artist merged commit b6141c2 into develop Aug 13, 2024
6 of 7 checks passed
@tea-artist tea-artist deleted the feat/created-modified-by branch August 13, 2024 08:34
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
@tea-artist @AliceLanniste
feat: created by and last modified by field (teableio#816)
66e2d47 
* feat: created by and last modified by field

* chore: adjust sequence

* chore: fix text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-w boris-w boris-w approved these changes

@Sky-FE Sky-FE Sky-FE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Last Updated By field
4 participants
@tea-artist @coveralls @Sky-FE @boris-w