Introduce add_phase helpers to add dynamic phases to steps
#3970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
commented
Aug 19, 2025
7cf8371 to
c83dde9
Compare
happz
reviewed
Oct 6, 2025
happz
reviewed
Oct 6, 2025
happz
approved these changes
Oct 6, 2025
therazix
reviewed
Oct 6, 2025
add_step and add_phase helpers to add dynamic phases to stepsadd_phase helpers to add dynamic phases to steps
Changed title. Any comments on the |
Yeah, we can keep them as TODOs now and improve later. |
therazix
approved these changes
Oct 7, 2025
happz
reviewed
Oct 7, 2025
happz
reviewed
Oct 7, 2025
happz
reviewed
Oct 7, 2025
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
psss
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily offers some interface to dynamically extend phases, which would be useful for external plugin creators.
Wanted to port the PrepareDistGit to use the add_step, but don't think it's doable right now, would require a bit more refactoring.
Note on my distinction between
TODOandFIXME.FIXMEs I want to be discussed and resolved within the PR, whileTODOs could be deferred for more investigation. Would probably be nice to make this a contributor guideline?Pull Request Checklist
(worth considering, do we add release notes for something that is meant more for developers?)