Switch to using the packaged yq
#4087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2025
|
Oh, |
happz
pushed a commit
that referenced
this pull request
Sep 25, 2025
This is a blocker for #4087. Basically because we are referencing the tmt repo itself in the tests, some of the tests are running steps from the `main` branch in this case https://github.com/teemtee/tmt/blob/b19b58c55eabfe5bd30fe26a33b7452c9d64fb1e/plans/main.fmf#L13-L22 even if I delete those in #4087 because it is taking the `main` ref instead of the current ref. For now a quick workaround is to first merge this in `main` to avoid installing `yq` if already present and then delete it later in #4087. Signed-off-by: Cristian Le <git@lecris.dev>
e869f4e to
e77c95e
Compare
tcornell-bus
approved these changes
Oct 3, 2025
therazix
approved these changes
Oct 3, 2025
psss
approved these changes
Oct 7, 2025
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
This is likely a no-op unlike the `jq -r` Signed-off-by: Cristian Le <git@lecris.dev>
It should not be necessary Signed-off-by: Cristian Le <git@lecris.dev>
yq does not have an equivalent, but instead we can just pipe it to `jq` Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already the packaged go-based
yqavailable. It does have some cli differences hence why there was quite a bit of debate on how to getpython-yqin as well, but realistically it should not make a difference for us since the corejqcompatibility is the same.Pull Request Checklist
yqflags-yis equivalent with-o yaml, however this is likely unnecessary (anymore?)-rseems to be a no-op now-emake sure the last output is notfalseornull: equivalent, just keep-ccompact output: no equivalent, just pipe it tojq -c-Ssort keys: change to"sort_keys(.)"